search

waku-org / nwaku

Waku node and protocol.
Other
183 stars 46 forks source link

fix: store v3 proto field numbers #2632

Closed SionoiS closed 3 weeks ago

SionoiS commented 3 weeks ago

Updated the protobuf field numbers according to the spec. https://github.com/vacp2p/rfc/tree/docs/new-store-v3-protocol/content/docs/rfcs/13#payloads

github-actions[bot] commented 3 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2632-rln-v1

Built from 010bb43e942ba02eafa36827e4ae998f7a80515e

github-actions[bot] commented 3 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2632-rln-v2

Built from 010bb43e942ba02eafa36827e4ae998f7a80515e

SionoiS commented 3 weeks ago

Looks good, but hard to judge without seeing the proto definition. I guess this will go with this: waku-org/waku-proto#22

this is the best we have. https://github.com/vacp2p/rfc/tree/docs/new-store-v3-protocol/content/docs/rfcs/13#payloads WIP

NagyZoltanPeter commented 3 weeks ago

Looks good, but hard to judge without seeing the proto definition. I guess this will go with this: waku-org/waku-proto#22

this is the best we have. https://github.com/vacp2p/rfc/tree/docs/new-store-v3-protocol/content/docs/rfcs/13#payloads WIP

Great thanks! I overlooked on it in the description. so far so good!