search

waku-org / nwaku

Waku node and protocol.
Other
183 stars 46 forks source link

chore: log enhancement for message reliability analysis #2640

Closed Ivansete-status closed 2 weeks ago

Ivansete-status commented 2 weeks ago

Description

The next modules are touched:

Issue

Add logging of hashes to all nodes - https://github.com/waku-org/nwaku/issues/2474

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2640-rln-v1

Built from c1793ad9eceb31888a19664fcc454c4c57592e72

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2640-rln-v2

Built from c1793ad9eceb31888a19664fcc454c4c57592e72

SionoiS commented 2 weeks ago

I understand the request since Nwaku logs are unusable BUT this "fix" will make it worst, we need to improve the logs not accommodate specific readers.

I disagree with this PR. We need clear guidelines and a concrete plan to improve the logs. Lets discuss this please!

Ivansete-status commented 2 weeks ago

@NagyZoltanPeter - for any unknown reason I couldn't change any single line of waku_lightpush/protocol.nim because that caused a SIGSEGV crash on macos tests. Did you face a similar issue?

NagyZoltanPeter commented 2 weeks ago

@NagyZoltanPeter - for any unknown reason I couldn't change any single line of waku_lightpush/protocol.nim because that caused a SIGSEGV crash on macos tests. Did you face a similar issue?

Hm... issue I had with MacOs tests I found in my PR and fixed. Nothing particular. But what change do you mean here?

Ivansete-status commented 1 week ago

@NagyZoltanPeter - for any unknown reason I couldn't change any single line of waku_lightpush/protocol.nim because that caused a SIGSEGV crash on macos tests. Did you face a similar issue?

Hm... issue I had with MacOs tests I found in my PR and fixed. Nothing particular. But what change do you mean here?

Sorry for late response. In the following PR it can be seen how the test fails on MacOS due to the changes in lighpush/protocol.nim: https://github.com/waku-org/nwaku/pull/2655 In this case there are many changes but it fail even with few log lines :)