search

waku-org / nwaku

Waku node and protocol.
Other
183 stars 46 forks source link

fix: rest/store/types: contentTopic -> content_topic #2646

Closed Ivansete-status closed 2 weeks ago

Ivansete-status commented 2 weeks ago

Description

Simple PR to change to properly return content_topic in Store REST reponses

Issue

closes https://github.com/waku-org/nwaku/issues/2582

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2646-rln-v1

Built from 164bea326da372ac188ddd8a584c5fda85e556e3

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2646-rln-v2

Built from 164bea326da372ac188ddd8a584c5fda85e556e3

Ivansete-status commented 2 weeks ago

Maybe better to use constants for such field names which are common across all protocols to avoid such issues in the future.

Thanks! I will consider for upcoming PRs