waku-org / nwaku

Waku node and protocol.
Other
183 stars 46 forks source link

fix: handle named sharding in enr #2647

Closed chaitanyaprem closed 2 weeks ago

chaitanyaprem commented 2 weeks ago

Description

fixes #2644

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2647-rln-v1

Built from ab5cdfebdbb078793438db5b0c44a45e7c60aab8

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2647-rln-v2

Built from ab5cdfebdbb078793438db5b0c44a45e7c60aab8

gabrielmer commented 2 weeks ago

Aren't we only adding a log in this PR? Or am I missing something?

chaitanyaprem commented 2 weeks ago

Aren't we only adding a log in this PR? Or am I missing something?

Nope, without this specific conditional..it goes into the else condition and causes issue reported in #2644 .