waku-org / nwaku

Waku node and protocol.

Other

183 stars 46 forks source link

fix(waku_keystore): sigsegv on different appInfo #2654

Closed rymnc closed 2 weeks ago

rymnc commented 2 weeks ago

fix(waku_keystore): sigsegv on different appInfo

Description

The matchingAppKeystore is set only when a match is found, else it is returned as void. This PR converts it to an option and adds a check before returning it so that we dont segfault :)

Changes

[x] converted matchingAppKeystore to an Option
[x] added test for this vector

Issue

closes #1934

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2654-rln-v1

Built from 6c5b00adb11a7f4ddd5102a06071689c30d4a668

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2654-rln-v2

Built from 6c5b00adb11a7f4ddd5102a06071689c30d4a668