waku-org / nwaku

Waku node and protocol.
Other
183 stars 46 forks source link

refactor: big refactor to add waku component in libwaku instead of only waku node #2658

Closed Ivansete-status closed 2 weeks ago

Ivansete-status commented 2 weeks ago

Description

With this PR we:

Issue

migrate DiscV5 and DNS Discovery from app.nim to waku_node.nim - https://github.com/waku-org/nwaku/issues/2452

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2658-rln-v1

Built from 92f68d9f339bfbb94730d255ca4f1ada098b5555

github-actions[bot] commented 2 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2658-rln-v2

Built from 92f68d9f339bfbb94730d255ca4f1ada098b5555

SionoiS commented 2 weeks ago

What about the make file? Needs to be changed too no?

Ivansete-status commented 2 weeks ago

What about the make file? Needs to be changed too no?

If you refer to wakunode2 I think we can't change that easily and would require coordination with infra, and Dockerfile changes too.