waku-org / waku-rust-bindings

Rust wrapper over go-waku ffi
14 stars 6 forks source link

ci: codecov and badges #30

Closed bacv closed 1 year ago

bacv commented 1 year ago

Using grcov and codecov.io to generate test coverage reports and related badges. In addition this PR adds crates.io, docs.rs and CI badges.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@aa06fcc). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #30 +/- ## ========================================= Coverage ? 17.75% ========================================= Files ? 18 Lines ? 1729 Branches ? 0 ========================================= Hits ? 307 Misses ? 1422 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

danielSanchezQ commented 1 year ago

@bacv apparently the main test is not being run: https://app.codecov.io/gh/waku-org/waku-rust-bindings/tree/ci%2Fcodecov/waku-bindings/tests Could we add that test for the coverage? Not sure if it is gonna work though.

bacv commented 1 year ago

@bacv apparently the main test is not being run: https://app.codecov.io/gh/waku-org/waku-rust-bindings/tree/ci%2Fcodecov/waku-bindings/tests Could we add that test for the coverage? Not sure if it is gonna work though.

Fixed it. The test was marked with #[ignore], so for now codecov tests are being run with cargo test --all-features -- --ignored. That's something that might need a change in a future. Anyway, after the update you can see a bunch of Message content: Hi from 🦀! lines in a build log, and I consider this a huge success.