search

waku-org / waku-rust-bindings

Rust wrapper over go-waku ffi
14 stars 6 forks source link

Use correct binding inside waku_stop method #37

Closed bacv closed 1 year ago

bacv commented 1 year ago

Use correct binding inside waku_stop method.

bacv commented 1 year ago

This change is supposed to be merged into discv5 branch. (waku-org/waku-rust-bindings#33)

danielSanchezQ commented 1 year ago

Uhm, it is the first time I see a SIGSEV in rust....and it comes from go.... 😆

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (discv5@f9b8c8e). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## discv5 #37 +/- ## ========================================= Coverage ? 55.68% ========================================= Files ? 18 Lines ? 1724 Branches ? 0 ========================================= Hits ? 960 Misses ? 764 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bacv commented 1 year ago

Added serial_test crate as dev dependency to run waku node related tests in sequence. If exclusive_running and waku_flow tests are started at the same time, one of those tests will close waku node from go-waku first and another will panic.