waku-org / waku-rust-bindings

Rust wrapper over go-waku ffi
14 stars 7 forks source link

Smoke tests for waku node #41

Closed bacv closed 1 year ago

bacv commented 1 year ago

Extracted common parts for testing waku nodes with different configurations. Simple node restart works without issue. When a node with peer connections is restarted, it fails to bind to a network interface. This might be related to how go-waku handles the waku node.

codecov-commenter commented 1 year ago

Codecov Report

Base: 56.03% // Head: 62.63% // Increases project coverage by +6.59% :tada:

Coverage data is based on head (172e2c1) compared to base (67e5aef). Patch coverage: 99.35% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #41 +/- ## ========================================== + Coverage 56.03% 62.63% +6.59% ========================================== Files 18 18 Lines 1715 1793 +78 ========================================== + Hits 961 1123 +162 + Misses 754 670 -84 ``` | [Impacted Files](https://codecov.io/gh/waku-org/waku-rust-bindings/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [waku-bindings/tests/node.rs](https://codecov.io/gh/waku-org/waku-rust-bindings/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-d2FrdS1iaW5kaW5ncy90ZXN0cy9ub2RlLnJz) | `99.46% <99.35%> (+2.19%)` | :arrow_up: | | [waku-bindings/src/node/mod.rs](https://codecov.io/gh/waku-org/waku-rust-bindings/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-d2FrdS1iaW5kaW5ncy9zcmMvbm9kZS9tb2QucnM=) | `74.86% <0.00%> (+4.81%)` | :arrow_up: | | [waku-bindings/src/general/mod.rs](https://codecov.io/gh/waku-org/waku-rust-bindings/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-d2FrdS1iaW5kaW5ncy9zcmMvZ2VuZXJhbC9tb2QucnM=) | `61.59% <0.00%> (+7.60%)` | :arrow_up: | | [waku-bindings/src/node/peers.rs](https://codecov.io/gh/waku-org/waku-rust-bindings/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-d2FrdS1iaW5kaW5ncy9zcmMvbm9kZS9wZWVycy5ycw==) | `75.20% <0.00%> (+12.80%)` | :arrow_up: | | [waku-bindings/src/events/mod.rs](https://codecov.io/gh/waku-org/waku-rust-bindings/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-d2FrdS1iaW5kaW5ncy9zcmMvZXZlbnRzL21vZC5ycw==) | `93.75% <0.00%> (+29.16%)` | :arrow_up: | | [waku-bindings/src/node/management.rs](https://codecov.io/gh/waku-org/waku-rust-bindings/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-d2FrdS1iaW5kaW5ncy9zcmMvbm9kZS9tYW5hZ2VtZW50LnJz) | `100.00% <0.00%> (+33.82%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

danielSanchezQ commented 1 year ago

Codecov Report

Base: 56.03% // Head: 62.63% // Increases project coverage by +6.59% 🎉

This is what I'm talking about!! @bacv nice done!