search

waku-org / waku-rust-bindings

Rust wrapper over go-waku ffi
14 stars 6 forks source link

Issue Suggestion - Exclude unnecessary files from the crate #60

Closed yokurang closed 1 year ago

yokurang commented 1 year ago

In this PR I address the issue by @danielSanchezQ to remove unnecessary files from the vendor folder. These exclusions are suggestions I made from studying the repository as a newbie.

Thank you, Alan

danielSanchezQ commented 1 year ago

Hi @yokurang !!!!, this looks like exactly what we need though. Thanks so much. @richard-ramos could you check as it is part of the vendor folder?

yokurang commented 1 year ago

Hi @danielSanchezQ, you are most welcome. I heard about waku-rust-bindings from Shivam who mentioned that you guys might be looking for interns to help with the repository. I find the project very interesting, and I'd love to be able to get more involved.

Best, Alan

richard-ramos commented 1 year ago

Hello, @yokurang, thank you for the PR! The following folders need to be kept, as they contain the code needed to build libwaku library:

    "vendor/mobile/*",
    "vendor/library/*",
yokurang commented 1 year ago

Hi @richard-ramos, I have added them back. Thank you very much.