search

waku-org / waku-rust-bindings

Rust wrapper over go-waku ffi
14 stars 6 forks source link

fix: content topic should accept strings #84

Closed richard-ramos closed 7 months ago

danielSanchezQ commented 8 months ago

Why strings? If reason is to support semver there Is a crate with types iirc.

richard-ramos commented 8 months ago

According to https://rfc.vac.dev/spec/51/#algorithm , the version is a UTF8 string.

cc-ing: @chaitanyaprem and @adklempner for their thoughts, since they originated this change in https://github.com/waku-org/go-waku/pull/874

chaitanyaprem commented 8 months ago

According to https://rfc.vac.dev/spec/51/#algorithm , the version is a UTF8 string.

cc-ing: @chaitanyaprem and @adklempner for their thoughts, since they originated this change in waku-org/go-waku#874

We were trying to align with the rfc here. But if I think about it, strings give flexibility in defining versions the way application wants (semver or some other versioning) and not restrict it to just numbers.