waku-org / waku-rust-bindings

Rust wrapper over go-waku ffi
14 stars 6 forks source link

refactor: node handle constructor and messageId on publish #98

Closed richard-ramos closed 4 months ago

richard-ramos commented 4 months ago

Changes:

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 73.46939% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 79.48%. Comparing base (8eb026d) to head (634a17f).

Files Patch % Lines
waku-bindings/tests/node.rs 57.14% 9 Missing :warning:
waku-bindings/src/utils.rs 20.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## handle-response #98 +/- ## =================================================== - Coverage 80.05% 79.48% -0.58% =================================================== Files 10 10 Lines 722 736 +14 =================================================== + Hits 578 585 +7 - Misses 144 151 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richard-ramos commented 4 months ago

ah! let's add that back in another PR

richard-ramos commented 4 months ago

@SionoiS I added back the typestate in commit https://github.com/waku-org/waku-rust-bindings/pull/98/commits/98c65583197f911f02b96fc603fb6f076d53a7da