Find the source of the multiple senator bug

wakystuf / ESG-Mod

An Endless Space 2 balance and overhaul mod

31 stars 4 forks source link

Find the source of the multiple senator bug #1280

Open Arpharnator opened 2 years ago

Arpharnator commented 2 years ago

Put your discoveries here (edit this message).

captaincobbs commented 1 year ago

What even was this bug?

wakystuf commented 6 months ago

This one was sometimes a hero skill (I forget which one--maybe the Seeker science skill?) was getting stacked multiple times on a system. I don't think we ever fixed it? But at the same time I haven't seen it for a while...

Arpharnator commented 6 months ago

It was the ratio food senator thingy, and it mostly happened after an election where you changed senators. After that sometimes the old hero would still keep having the senator skill applied, and new heroes would also do so at random.

captaincobbs commented 6 months ago

This one was sometimes a hero skill (I forget which one--maybe the Seeker science skill?) was getting stacked multiple times on a system. I don't think we ever fixed it? But at the same time I haven't seen it for a while...

We could just make the effect binary with a Modifier="Max"

captaincobbs commented 6 months ago

It was the ratio food senator thingy, and it mostly happened after an election where you changed senators. After that sometimes the old hero would still keep having the senator skill applied, and new heroes would also do so at random.

That sounds like a vanilla bug, not an ESG bug

captaincobbs commented 2 months ago

Do the new operations added with ReAwakening allow us to fix this?

wakystuf commented 2 months ago

I was never able to reliably replicate this issue, so it's hard to say. Is there a sure-fire way to even trigger this bug to test? That's honestly the only reason I haven't tried harder to fix it

Arpharnator commented 2 months ago

The way I remember being able to trigger it as follows :

Play Horatio (moslty because I haven't tested much outside of that)
Get the food skill with the hero on senate.
At turn 10, swap to religious
Try to get the religious Horatio Hero and get him as the religious senator
Give him the food senator skill. From this point onwards, either the old hero's skill stays active just after the change, or you should have a chance every turn for the old hero to spontaneously manifest his skill back into the senate. Same for other Horatio heroes.