wakystuf / ESG-Mod

An Endless Space 2 balance and overhaul mod
31 stars 4 forks source link

Pop Collection 3's are wildly variable in quality #1336

Closed wakystuf closed 1 year ago

wakystuf commented 2 years ago

Longer-term issue, but probably should get a balance pass at some point

FluffiestPrincess commented 1 year ago

I made a google drive folder with screenshots of all the existing Pop Collection boni, in case that helps. Unless someone wants to unilaterally decide what they should be changed to, I guess this has to be a discussion.

wakystuf commented 1 year ago

Thanks! Quite helpful. I'll post a spreadsheet with proposed changes probably later this week.

wakystuf commented 1 year ago

Chnages:

image

captaincobbs commented 1 year ago

I have no problems with any of these from a design perspective, though I worry that the +5% influence is going to be a bit busted since that'll include pirate hulls.

wakystuf commented 1 year ago

Nah, it works fine. It's looking for Hull Types, not ship designs. Otherwise the CPs effect that is based on hulls would go crazy with mercenaries, and it does not.

captaincobbs commented 1 year ago

ah so ship classes?

wakystuf commented 1 year ago

Basically yes, although the variable is literally HullTypes

wakystuf commented 1 year ago

This was a huge pain (particularly the GUI with the setting), but it all works now except for one minor GUI bug: the lines that use SearchValueFromPath don't show up properly on the tooltip (though they do show up if you hover over collection III). @captaincobbs do you have any idea why that would happen?

captaincobbs commented 1 year ago

I believe they're just a special case, never quite figured out what exactly what was different about them, but they always seem to have tooltip or gui problems. I tend to hide them and make a fake tooltip for them.

wakystuf commented 1 year ago

Yeah, the problem is that if I use TooltipHidden=True, then I'll end up hiding the effects. For example, if there is a collection III that affects system science, then I don't want it to hide that number in the system view of science

captaincobbs commented 1 year ago

use TooltipHiddenIfPathInvalid, then set the conditional path, and use UselessForTooltip property, then override the tooltip with whatever

wakystuf commented 1 year ago

Nah that won't work since then it will hide they will show up twice on the tooltip