search

wakystuf / ESG-Mod

An Endless Space 2 balance and overhaul mod
31 stars 4 forks source link

All Hands Dictum doesn't affect terraforming cost #1398

Closed FluffiestPrincess closed 1 year ago

FluffiestPrincess commented 1 year ago

All Hands Dictum is an Ecologist party law, P04L04. Definition follows:

  <SimulationDescriptor Name="LawEffectP04L04_ESG" Type="LawEffect">
    <BinaryModifier TargetProperty="ReductionCostReduction" Operation="Addition" Left="-0.1" BinaryOperation="Multiplication" Right="$(LawActivationTimeStock)" TooltipOverride="%LawEffectP04L05_ESGTooltipOverride"/>
    <Modifier TargetProperty="ReductionModifier" Operation="Percent" Value="$(ReductionCostReduction)" Path="../ClassEmpire" TooltipHidden="true"/>
    <BinaryModifier TargetProperty="PopBoostingCostReductionActivationTime" Operation="Addition" Left="-0.1" BinaryOperation="Multiplication" Right="$(LawActivationTimeStock)" TooltipHidden="true"/>
    <Modifier TargetProperty="PopulationBoostCostMultiplier" Operation="Percent" Value="$(PopBoostingCostReductionActivationTime)" Path="../ClassEmpire" TooltipHidden="true"/>
    <Modifier TargetProperty="DemocracyLawsDiversityHasEcologist" Operation="Addition" Value="1" Path="../ClassEmpire" TooltipOverride="%LawEffectP04L04_ESGTooltipOverride"/>
    <BinaryModifier TargetProperty="BonusFromTerraformedHot" Operation="Addition" Left="$(TerraformedHotPlanets)" BinaryOperation="Multiplication" Right="0.05" Path="../ClassEmpire/ClassColonizedStarSystem" SearchValueFromPath="true" TooltipHidden="true"/>
    <BinaryModifier TargetProperty="BonusFromTerraformedTemperate" Operation="Addition" Left="$(TerraformedTemperatePlanets)" BinaryOperation="Multiplication" Right="0.05" Path="../ClassEmpire/ClassColonizedStarSystem" SearchValueFromPath="true" TooltipHidden="true"/>
    <BinaryModifier TargetProperty="BonusFromTerraformedCold" Operation="Addition" Left="$(TerraformedColdPlanets)" BinaryOperation="Multiplication" Right="0.05" Path="../ClassEmpire/ClassColonizedStarSystem" SearchValueFromPath="true" TooltipOverride="%LawEffectP04L04_ESGTerraformEffectOverride"/>
  </SimulationDescriptor>

I checked the simulation explorer. The modifier to ReductionCostReduction on the law itself is being applied, the modifier to ReductionModifier on ClassEmpire is not.

captaincobbs commented 1 year ago

Oops forgot to make it Composition="Sum"

wakystuf commented 1 year ago

Oh, I just noticed this issue. I spotted the same thing when I was reviewing that last PR and went ahead and included the fix there. Should be all set now