search

wakystuf / ESG-Mod

An Endless Space 2 balance and overhaul mod
31 stars 4 forks source link

Patch Preview -- Ships have 0 hp max, entering battle causes freeze #1437

Closed Arpharnator closed 2 months ago

Arpharnator commented 4 months ago

image image

wakystuf commented 4 months ago

Good catch; I believe I just fixed this one. When Cobbs did the initial merge, he added ClassSection, which we don't need, and somehow included certain random properties from ClassShip (related to trade value) but left out others (like health).

Why, @captaincobbs why??

Arpharnator commented 4 months ago

this works

captaincobbs commented 2 months ago

Good catch; I believe I just fixed this one. When Cobbs did the initial merge, he added ClassSection, which we don't need, and somehow included certain random properties from ClassShip (related to trade value) but left out others (like health).

Why, @captaincobbs why??

Kill yourself

Arpharnator commented 2 months ago

Not very professional innit

wakystuf commented 2 months ago

Indeed. Step 1: Break things Step 2: Make me fix the broken things Step 3: Grump at me for successfully fixing the broken things Step 4: Profit?