wakystuf / ESG-Mod

An Endless Space 2 balance and overhaul mod
31 stars 4 forks source link

Fix Academy relations defaulting to hostile #1464

Closed 107g closed 6 months ago

107g commented 6 months ago

Academy relations default to 'Hostile' after an Academy request is over, even if you end up in the lead. This is due to the missing attributes MinimumRelationPoints and Type on the DiplomaticRelationState objects in the DiplomaticRelationState[Academy].xml file.

As the AcademyDiplomaticRelationStateHostile is not defined in the mod (thus taking default ES2 parameters, with the expected attributes), the game would default to this state.

This pull request aims to reintroduce these missing attributes, thus fixing the bug.