search

wakystuf / ESG-Mod

An Endless Space 2 balance and overhaul mod
31 stars 4 forks source link

Fix Academy Relations always being Hostile #1465

Closed captaincobbs closed 5 months ago

captaincobbs commented 6 months ago

Was fixed in #1464, just adding this so it can be documented

107g commented 6 months ago

AcademyHostile

Academy relations is positive and is yet marked as 'Hostile'

When looking through the Diplomacy/DiplomaticRelationStates[Academy].xml file, you can see that there are 3 DiplomaticRelationState definitions, one for Neutral, one for War, one for Ally. None of them have the MinimumRelationPoints Attribute that is found in the vanilla version. Since Hostile and Friendly relation DiplomaticRelationState definitions are not in the mod, you can either be Hostile or Friendly with the Academy. Defaulting to Hostile as you don't have the 15 Points necessary to be considered as friend.

captaincobbs commented 6 months ago

AcademyHostile

Academy relations is positive and is yet marked as 'Hostile'

When looking through the Diplomacy/DiplomaticRelationStates[Academy].xml file, you can see that there are 3 DiplomaticRelationState definitions, one for Neutral, one for War, one for Ally. None of them have the MinimumRelationPoints Attribute that is found in the vanilla version. Since Hostile and Friendly relation DiplomaticRelationState definitions are not in the mod, you can either be Hostile or Friendly with the Academy. Defaulting to Hostile as you don't have the 15 Points necessary to be considered as friend.

How would you like to be credited in the list of ESG contributors?

107g commented 6 months ago

Uhm, I dunno? Not used to ppl asking me this. Maybe credit me in the next minor release notes or something?

captaincobbs commented 6 months ago

Uhm, I dunno? Not used to ppl asking me this. Maybe credit me in the next minor release notes or something?

I more mean like, what would you like to be credited as? You'll be added to the list of contributors for this :)

107g commented 6 months ago

Ah! I see :) Credit me as 'StatusAtlas_'