search

wakystuf / ESG-Mod

An Endless Space 2 balance and overhaul mod
31 stars 4 forks source link

Moar colors! #1467

Closed Tat011 closed 2 months ago

Tat011 commented 3 months ago

https://github.com/wakystuf/ESG-Mod/issues/1466

wakystuf commented 2 months ago

I'll take a closer look when I have time, but a few quick questions: 1) Is there a documented list someplace in an Issue for everything that's changing here? It looks like it's more than only the colors, right? 2) Are the changes to StarSystemNodeDefinitions simply sorting the planets into the correct temperature-order (without changing the actual planets, anomalies, etc)? That would be great if so actually--it's something that's slightly bugged me for a long time but I haven't taken the time to fix it. 3) I think it's fine to reorganize some of the localization work, as long as you're removing the relevant portions from the non-english localizations as well--is that already included in one of the files? Otherwise the translators will get very confused, I think.

Tat011 commented 2 months ago

1 Im pretty sure all the changes that arent small tweaks i made come with a short description 2 as meantioned in the update thing, yes it changes the order of the planets to be correct and also diversifies the star types so it's not oops all white 3 I havent touched other language files

wakystuf commented 2 months ago

OK, got it, thanks. I went through this more carefully now and I think it generally looks good (I still need to go really really carefully through the StarSystemNodeDefinitions.xml, since that one is easy to make a mistake in). Just 2 things: 1) Please do use the Issues function for documentation (IE, create issues for the various items you're changing, and describe what changed). For GUI changes, fine to be more high-level (e.g. more names), but for the gameplay changes (e.g. Hissho pop traits), ideal to go into more detail. That way whatever poor soul does the documentation has an easier time of it. 2) For the localization changes, please make sure you make the conforming organizational changes in the alternate language equivalents (so no need to translate anything, but like for the names, just migrate the old ones over so that it uses the same organizational scheme as before). Does that make sense?

I'll also circle back on the node definitions. I think they looked fine, but want to go through them really carefully.

captaincobbs commented 2 months ago

Ok, only request is that you create issues for every other thing you've worked on so it can be added to the changelog

captaincobbs commented 2 months ago

Great job though, no complaints