search

wala / ML

Eclipse Public License 2.0
23 stars 17 forks source link

Support for analyzing multiple local modules (multi-module projects) by using PYTHONPATH #176

Closed khatchad closed 2 months ago

khatchad commented 3 months ago
khatchad commented 3 months ago

This is only supported by Jython 3, but http://github.com/wala/ML is still working with Jython 2 due to #42. Thus, I"m unsure whether this should be merged here.

khatchad commented 3 months ago

We can merge it, but the new functionality isn't being tested here until #42 is fixed and both com.ibm.wala.cast.python.ml and com.ibm.wala.cast.python.ml.tests are configured to use Jython 3.

msridhar commented 3 months ago

@khatchad how critically do you need this merged? I probably won't have time to do a real review for a couple of weeks, but I can stamp it if you need it in quickly

khatchad commented 3 months ago

We've been using our fork, so no rush.

msridhar commented 2 months ago

@khatchad with 236 modified files this is rather intimidating to review. Will it be easier once some other PRs land?

khatchad commented 2 months ago

@khatchad with 236 modified files this is rather intimidating to review. Will it be easier once some other PRs land?

Unfortunately, this is quite a pervasive change. We're basically adding something like a CLASSPATH or a project starting point here. Thus, there's quite a bit of plumbing involved. There are also some metadata changes and plenty of varying tests. I tried to document the other changes as best I could. Hopefully that helps somewhat. Sorry about that.