wala / WALA

T.J. Watson Libraries for Analysis, with frontends for Java, Android, and JavaScript, and may common static program analyses
http://github.com/wala/WALA
Eclipse Public License 2.0
764 stars 223 forks source link

Bump Error Prone to 2.35.1 and enable javac `-parameters` flag #1458

Closed msridhar closed 2 weeks ago

msridhar commented 2 weeks ago

The -parameters flag is required for certain checks like ArgumentSelectionDefectChecker. We enable a couple of those checks; they don't turn up any issues at the moment. In a follow up I'd like to enable BooleanParameter and auto-fix extant issues.

github-actions[bot] commented 2 weeks ago

Test Results

  813 files  ±0    813 suites  ±0   4h 12m 11s ⏱️ + 22m 45s   735 tests ±0    718 ✅ ±0   17 💤 ±0  0 ❌ ±0  5 029 runs  ±0  4 908 ✅ ±0  121 💤 ±0  0 ❌ ±0 

Results for commit 1c11ec6d. ± Comparison against base commit 60103481.

This pull request removes 116 and adds 116 tests. Note that renamed tests count towards both. ``` com.ibm.wala.dalvik.test.callGraph.droidbench.AliasingTest ‑ [1] Aliasing/Merge1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [10] AndroidSpecific/PublicAPIField1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [11] AndroidSpecific/PublicAPIField2.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [1] AndroidSpecific/ApplicationModeling1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [2] AndroidSpecific/DirectLeak1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [3] AndroidSpecific/InactiveActivity.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [4] AndroidSpecific/Library2.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [5] AndroidSpecific/LogNoLeak.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [6] AndroidSpecific/Obfuscation1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [7] AndroidSpecific/PrivateDataLeak1.apk … ``` ``` com.ibm.wala.dalvik.test.callGraph.droidbench.AliasingTest ‑ [1] testParameters=Aliasing/Merge1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [10] testParameters=AndroidSpecific/PublicAPIField1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [11] testParameters=AndroidSpecific/PublicAPIField2.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [1] testParameters=AndroidSpecific/ApplicationModeling1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [2] testParameters=AndroidSpecific/DirectLeak1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [3] testParameters=AndroidSpecific/InactiveActivity.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [4] testParameters=AndroidSpecific/Library2.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [5] testParameters=AndroidSpecific/LogNoLeak.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [6] testParameters=AndroidSpecific/Obfuscation1.apk com.ibm.wala.dalvik.test.callGraph.droidbench.AndroidSpecificTest ‑ [7] testParameters=AndroidSpecific/PrivateDataLeak1.apk … ```