search

wala / WALA

T.J. Watson Libraries for Analysis, with frontends for Java, Android, and JavaScript, and may common static program analyses
http://github.com/wala/WALA
Eclipse Public License 2.0
760 stars 221 forks source link

Debug and verbose output is not consistent #218

Open khatchad opened 7 years ago

khatchad commented 7 years ago

Controlling debugging and verbose output doesn't seem to be consistent. There are multiple constants being used, some of which are hard-coded and others controlled by an environmental variable. It would be great to have a consistent way to control logging.

khatchad commented 7 years ago

Some problematic entities include:

  1. com.ibm.wala.fixedpoint.impl.AbstractFixedPointSolver.DEBUG
  2. com.ibm.wala.fixedpoint.impl.AbstractFixedPointSolver.verbose
  3. com.ibm.wala.fixedpoint.impl.AbstractFixedPointSolver.MORE_VERBOSE
  4. com.ibm.wala.ipa.callgraph.propagation.StandardSolver.DEBUG_PHASES
  5. com.ibm.wala.dataflow.ssa.SSAInference.DEBUG
khatchad commented 7 years ago

It might be more consistent to use something like the java.util.Logging package and have things like phases be logged at a FINE or FINER level.

msridhar commented 7 years ago

Pull requests welcome on this one. Should be a good starter bug. I agree with introducing a proper logging API

On Wed, Aug 9, 2017, 3:18 PM Raffi Khatchadourian notifications@github.com wrote:

It might be more consistent to use something like the java.util.Logging package and have things like phases be logged at a FINE or FINER level.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wala/WALA/issues/218#issuecomment-321396994, or mute the thread https://github.com/notifications/unsubscribe-auth/AALyUWuQsGSW4ACTQidVthOrnQem0VLCks5sWjA7gaJpZM4OyN7n .

khatchad commented 7 years ago

@msridhar Could add a "help wanted" label (but not sure how much that would help).