walaj / SeqLib

C++ htslib/bwa-mem/fermi interface for interrogating sequence data
http://bioinformatics.oxfordjournals.org/content/early/2016/12/21/bioinformatics.btw741.full.pdf+html
Other
133 stars 36 forks source link

ChrName function in BamRecord Class logic wrong #35

Closed wulj2 closed 5 years ago

wulj2 commented 5 years ago

hello, I have found a little logic mistake in a function listed below, would you please fix it? branch: master file: https://github.com/walaj/SeqLib/blob/master/SeqLib/BamRecord.h function: inline std::string ChrName(const SeqLib::BamHeader& h) const line: 829 code: if (h.isEmpty()) should be if (!h.isEmpty())

walaj commented 5 years ago

Thanks for finding this! Fixed.