search

walaj / SeqLib

C++ htslib/bwa-mem/fermi interface for interrogating sequence data
http://bioinformatics.oxfordjournals.org/content/early/2016/12/21/bioinformatics.btw741.full.pdf+html
Other
132 stars 36 forks source link

Update submodules to work with GCC 10 #67

Open julianhess opened 1 year ago

julianhess commented 1 year ago

Fixes https://github.com/walaj/SeqLib/issues/66

julianhess commented 1 year ago

I made this PR against the jhess branch (PR'd here: https://github.com/walaj/SeqLib/pull/64), which uses the system htslib, rather than embedding it as a submodule. (I still have to update the tests to get that one merged 😬).

walaj commented 9 months ago

Hi Julian -- so I'm looking back and I think I had made some of these submodule changes above that you suggested, but on the "cmake" branch. Do you use that branch or have capacity to see if that works on your system / fixes theses issues?

julianhess commented 9 months ago

I have not yet used that branch, but would be happy to switch over. Your message is really apropos; I'm actually hacking on a tool that uses SeqLib right now.

walaj commented 9 months ago

That would be great if you could try it and see if that works, then I can just move it over the main. I haven't built my own tool with SeqLib in a while, you're the world expert on this now!

On Tue, Jan 30, 2024 at 8:50 PM julianhess @.***> wrote:

I have not yet used that branch, but would be happy to switch over. Your message is really apropos; I'm actually hacking on a tool that uses SeqLib right now.

— Reply to this email directly, view it on GitHub https://github.com/walaj/SeqLib/pull/67#issuecomment-1918218251, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUZ7CAJGXJQHULLZZ2JVN3YRGPNNAVCNFSM6AAAAAATACF3JWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJYGIYTQMRVGE . You are receiving this because you commented.Message ID: @.***>