walbourn / directx-sdk-samples

This repo contains Direct3D 11, XInput, and XAudio2 samples C++ samples from the legacy DirectX SDK updated to build using the Windows 10 SDK
https://walbourn.github.io/directx-sdk-samples-catalog/
MIT License
1.38k stars 369 forks source link

VS 2019 projects #14

Closed walbourn closed 4 years ago

jpark37 commented 4 years ago

I tried opening BasicHLSL11_2019_Win10.sln using Explorer, and VS 2017 was used by the VS version selector. I think the solution files need: # Visual Studio 16

Instead of: # Visual Studio 15

walbourn commented 4 years ago

Sorry, I expected the project upgrade to fix this. VS 2019 uses # Visual Studio Version 16.

Fixed in this commit

jpark37 commented 4 years ago

CMake seems to generate # Visual Studio 16 and the selector is smart enough to accept it. VS itself seems to do # Visual Studio Version 16