search

waldner / cert-manager-webhook-he

`cert-manager` webook to use HE DNS as ACME DNS01 solver
GNU General Public License v3.0
8 stars 3 forks source link

Add imagePullSecrets to deployment template #5

Closed mpsOxygen closed 7 months ago

mpsOxygen commented 7 months ago

Hello, it's me again

I am pulling the chart and the image from an internal Harbor registry that replicates the one you have on ghcr. Unfortunately it requires authentication so I've added a pull request to add imagePullSecrets to the helm chart Deployment template.

Thank you for your time and patience! :)

waldner commented 7 months ago

Right, personally, I'd put the pull secret in the service account but since there's just a single deployment here it doesn't really matter. Since this repo (as many other cert-manager webooks) is based on the sample repository here https://github.com/cert-manager/webhook-example, you might want to submit a PR with this change there as well.

mpsOxygen commented 7 months ago

Thanks! Will do.

I thought about putting it in the SA, but since there is only one Deployment I just thought it was easier.