search

waldo-seg / waldo

image-segmentation and text-localization
Apache License 2.0
13 stars 13 forks source link

mask generation for text locatiozation #2

Closed aarora8 closed 6 years ago

aarora8 commented 6 years ago

Adding data download First version of mask generation.

danpovey commented 6 years ago

I'm fine to merge without too much review for now.

On Sun, Apr 29, 2018 at 4:43 PM, Hossein Hadian notifications@github.com wrote:

@hhadian commented on this pull request.

some comments.... @danpovey https://github.com/danpovey should we merge w/o too much review so that the project proceeds faster?

In .gitignore https://github.com/waldo-seg/waldo/pull/2#discussion_r184894199:

@@ -57,3 +57,6 @@ GSYMS /egs//v/plp /egs//v/exp /egs//v/data + +# .idea +.idea/

Is this for some kind of IDE?

In README.md https://github.com/waldo-seg/waldo/pull/2#discussion_r184894226:

@@ -1,2 +1,5 @@

waldo

  • image-segmentation and text-localization
  • image-segmentation and text-localization

  • +/Users/ashisharora/Desktop/scale2018/waldo_text_loc_mask/waldo

I guess you have added this by mistake.

In egs/madcat_arabic/v1/path.sh https://github.com/waldo-seg/waldo/pull/2#discussion_r184894250:

@@ -0,0 +1 @@ +export LC_ALL=C

add a new line at the end. also for other files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/waldo-seg/waldo/pull/2#pullrequestreview-116177725, or mute the thread https://github.com/notifications/unsubscribe-auth/ADJVu-dTuFtTdw7f9hmTQW-SK_Axxvwyks5ttiXogaJpZM4Tr8G0 .

aarora8 commented 6 years ago

Thank you. It is ready for merge

hhadian commented 6 years ago

Thanks Ashish! Merged.