waldo-seg / waldo

image-segmentation and text-localization
Apache License 2.0
13 stars 13 forks source link

negating the offsets #47

Closed danpovey closed 6 years ago

danpovey commented 6 years ago

Guys, this is what I mentioned on the list last night. I think this is the reason Yiwen is not getting perfect results with the oracle masks. On this line, you need to negate the offsets. If you want the current pixel to contain the reference at this pixel plus the offset, you need to roll the image with the negative of the offset.

https://github.com/waldo-seg/waldo/blob/3566eaec5752796eb569e32d2f95b9e5effe8165/scripts/waldo/data_manipulation.py#L160

YiwenShaoStephen commented 6 years ago

Got it. I will fix it.