data path fixed; requirement added

[desh2608]

Fixed issues pointed out by @jtrmal

[jtrmal]

I think also this line: https://github.com/waldo-seg/waldo/blob/ec46860e4b5b41af001c35de2728d74fc79ebf8c/egs/dsb2018/v1/local/scoring.py#L37

should be removed

[desh2608]

@jtrmal The dsb2018 is maintained by @YiwenShaoStephen, so maybe he could look into your suggestion in the scoring.py file.

[YiwenShaoStephen]

@jtrmal Yes, it can be removed. It just gives me a sense of progress.

[jtrmal]

All right, but those are only printed during scoring (that doesn't take that long) and without any additional information, so you will get only N strangely looking lines without any additional info, i.e. you end up with handful of screens of an incomprehensible code, so I think the utility is close to zero (or maybe non-zero to you and zero to others). y.

On Tue, Jun 19, 2018 at 11:08 PM Yiwen Shao notifications@github.com wrote:

@jtrmal https://github.com/jtrmal Yes, it can be removed. It just gives me a sense of progress.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/waldo-seg/waldo/pull/76#issuecomment-398610209, or mute the thread https://github.com/notifications/unsubscribe-auth/AKisX_nYblRA5WdY8BVtXCwDOmZ3_YL2ks5t-bytgaJpZM4UuHEq .

[YiwenShaoStephen]

Sure, it's only actually for my debug usage then. Anyway, the scoring script is for dsb only, not written for other datasets since different task have different metric.

[jtrmal]

You understand that you don't write the code for yourself only, right? y.

On Tue, Jun 19, 2018 at 11:25 PM Yiwen Shao notifications@github.com wrote:

Sure, it's only actually for my debug usage then. Anyway, the scoring script is for dsb only, not written for other datasets since different task have different metric.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/waldo-seg/waldo/pull/76#issuecomment-398612471, or mute the thread https://github.com/notifications/unsubscribe-auth/AKisX8zKZpDwhv07x-gB01ABsmy0Nup2ks5t-cCvgaJpZM4UuHEq .

[YiwenShaoStephen]

Yeah... I mean Desh can delete it in next commit...

[jtrmal]

OK, great, thanks! y.

On Tue, Jun 19, 2018 at 11:29 PM Yiwen Shao notifications@github.com wrote:

Yeah... I mean Desh can delete it in next commit...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/waldo-seg/waldo/pull/76#issuecomment-398613042, or mute the thread https://github.com/notifications/unsubscribe-auth/AKisX4yCkZQiTNKt4xDCv-r2Fea73Lykks5t-cGQgaJpZM4UuHEq .

[desh2608]

Done.

[danpovey]

assuming OK; will merge.