search

waldo-seg / waldo

image-segmentation and text-localization
Apache License 2.0
13 stars 13 forks source link

add quotes to package names #78

Closed huangruizhe closed 6 years ago

huangruizhe commented 6 years ago

Thanks Jan Trmal for pointing this out.

yes, it's there, but when the script suggests what packages are missing, it prints only something like

pip3 install --user tensorboard_logger matplotlib>=2.2.2

most people will only copy and paste the line, which will cause the > character to be interpreted by bash as redirection. That could cause even more problems if the ">" character wasn't part of the last package or if there were more package names including that character.

That's why I say those packages names should be quoted (as in they should have quotes around them), like this pip3 install --user tensorboard_logger "matplotlib>=2.2.2" (or just simply pip3 install --user "tensorboard_logger" "matplotlib>=2.2.2")