search

waldo1001 / crs-al-language-extension

Make working with the (Dynamics NAV / 365) AL Language easier and more efficient.
MIT License
34 stars 43 forks source link

Default Filename does not match best practice after rename #119

Closed ChrisBlankDe closed 5 years ago

ChrisBlankDe commented 5 years ago

If FileNamePatternExtensions and FileNamePattern is not configured in settings, page extensions are named like Pag-Ext50100.CustomerListExt.al. This does not match the best practice from Best Practices for AL - File naming.

As I read the docs the file should be named PagExt21-Ext50100.CustomerListExt.al.

I think the default setting should match the best practice from Microsoft.

What do you think?

waldo1001 commented 5 years ago

Well - Microsoft changed its own rules - I had implemented the default, but now they changed.. .

The problem is that when I change the default myself, a lot of people that use the default setting, might have unexpected file name changes. And if they don't have the "RenameWithGit" switched on (which preserves the history of the file), it might be something they will blame me for .. :(.

an option would be that in the same update, I make the "RenameWithGit" default, but I'm not that confident of that feature just yet - recently went through a lot of fuss to make it work - which it does now, but not sure if I covered all scenarios.. :-/

So, what do you think .. ?

ChrisBlankDe commented 5 years ago

Tricky question. On the one hand, we should all stick to the latest Microsoft guidelines, on the other hand, I like your pattern (the old one from Microsoft) better and would hate you to change it just like that. 😉

If I think about it again, maybe we shouldn't make any changes at this point. Especially because I trust Microsoft to change this again... If you didn't know, see here: https://www.yammer.com/dynamicsnavdev/#/threads/show?threadId=48602595835904

waldo1001 commented 5 years ago

If you don't mind - I'm gong to leave it as is .. and close this comment. I AM going to implement the other one (controladdins) though .. .

thanks again for the feedback!