search

waldo1001 / crs-al-language-extension

Make working with the (Dynamics NAV / 365) AL Language easier and more efficient.
MIT License
34 stars 43 forks source link

Reorganizing controladdin ignores CRS.RemoveSuffixFromFilename option #131

Closed nicolassaleron closed 5 years ago

nicolassaleron commented 5 years ago

Hello,

After the last release (1.1.15) and the new feature to reorganize controladdin, I have noticed the suffix is kept on the folder name automatically created.

For instance if I have:

controladdin "My Control Add In SFX" { }

where SFX is my suffix, the controladdin file is renamed ConAddin.MyControlAddIn.al but it is moved to /src/controladdin/My Control Add In SFX/

Is it done on purpose?

The folder name also keeps spaces and not filenames. It seems to create error at runtime when their is spaces in the script/css path.

waldo1001 commented 5 years ago

Not on purpose ... I will take a look...

Sent from my iPhone

On 6 Jul 2019, at 09:11, nicolassaleron notifications@github.com<mailto:notifications@github.com> wrote:

Hello,

After the last release (1.1.15) and the new feature to reorganize controladdin, I have noticed the suffix is kept on the folder name automatically created.

For instance if I have:

controladdin "My Control Add In SFX" { }

where SFX is my suffix, the controladdin file is renamed ConAddin.MyControlAddIn.al but it is moved to /src/controladdin/My Control Add In SFX/

Is it done on purpose?

The folder name also keeps spaces and not filenames. It seems to create error at runtime when their is spaces in the script/css path.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/waldo1001/crs-al-language-extension/issues/131?email_source=notifications&email_token=AC4HGTVUGG3EGPT4GEMKDELP6BATBA5CNFSM4H6SYRX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5UWC6Q, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC4HGTRSFXCB557I4RN6PJLP6BATBANCNFSM4H6SYRXQ.

waldo1001 commented 5 years ago

I think I solved the issues - using the "short" names now ;-). Update is online! Thanks for taking the time to report this with extensive information :-) - big help!