search

waldo1001 / crs-al-language-extension

Make working with the (Dynamics NAV / 365) AL Language easier and more efficient.
MIT License
34 stars 43 forks source link

Added new Guided Experience (Assisted Setup) Snippet #231

Closed christianbraeunlich closed 2 years ago

christianbraeunlich commented 2 years ago

This PR attempts to add a new Snippet which is based on the Assisted Setup Snippets.

The new Snippet uses the Guided Experience Codeunit in favor of the "Assisted Setup" Codeunit.

Please try this Snippet on your own and provide some feedback. Thanks in advance.

EDIT: Site note - for the future I would recommend to create a new file called Onboarding.json and put the related Snippets into that file instead of the DesignPatterns.json.

waldo1001 commented 2 years ago

Olala, that's massively overdue - thanks so much :-). Totally forgot (now you know I never use this myself ;-))

Can I suggest a change?

Let's have the "current" version as the default, so "tassistedsetupwaldo" would be the new one, and e.g. "tassistedsetupwaldoBeforeV18" the old?

christianbraeunlich commented 2 years ago

For sure I know :-) Suggestions are always welcome! Please keep in mind that there might be some additional requests in the future, so let's agree not to mention this over and over again :D

So there will be three snippets, am I correct?

What do you say about the provided Video URL? If the content is alright I would just replace it by https://www.youtube.com/embed/fitTMAwHcJw which matches the specific purpose.

I would also start to separate these snippets into a new file Onboarding.json. Is that ok?

I'd have to ask this: why do we need to provide these two lines:

Wouldn't the label be enough? I haven't test it although I should think about doing so in the first place.

waldo1001 commented 2 years ago

Lol, I didn't notice the url :-). But sure - love it 🤣. ok for the filenames and moving the snippets - makes lots of sense! I'm not completely sure about the guidedexperience-methods .. not using that myself (yet). I'd just leave it as is ..

christianbraeunlich commented 2 years ago

Tested the behavior with simple xliff translation and it looks good to me overall. So that's when I decided to remove that bit of translation logic. Feel free to correct me on this one.

christianbraeunlich commented 2 years ago

Found a mistake by me: the package.json has to be extended by the new snippet file will add this later this day ...

christianbraeunlich commented 2 years ago

What do you think? Is this PR now complete or shall we add some more things for the new "Guided Experience" assisted setup?

waldo1001 commented 2 years ago

Let's gather info on the people using it ;-).