search

waldo1001 / crs-al-language-extension

Make working with the (Dynamics NAV / 365) AL Language easier and more efficient.
MIT License
34 stars 42 forks source link

:sparkles: Add Support for Arrays in Report Columns #258

Closed pri-kise closed 2 years ago

pri-kise commented 2 years ago

It is very common to use array values in Report Columns. To Support adding of a prefix. I updated the Regex for Report Columns

waldo1001 commented 2 years ago

Thanks for the PR, but I'm afraid there are quite some missing components:

The changes in the test-file doesn't fail the tests. And the changes on the action isn't going to do anything to the columns, so I the regex was added to the wrong place.

I do understand the issue though, and I'll foresee a fix, based on your regex!

pri-kise commented 2 years ago

@waldo1001 thanks for taking this attempt over and make i work. I must have been to tired this morning, to make it correctly.

I wasn't sure if it's really needed, but maybe the regex for PageExtensions should be updated to include Array-Support, too. E.g. taking a look in the BaseApp there are many pages that use arrays together with Dimensions.

waldo1001 commented 2 years ago

it would be great if you could create an issue (with example), because I don't really have the time to work on this atm.. :(