search

waldronlab / BugSigDB

A microbial signatures database
https://bugsigdb.org
7 stars 6 forks source link

Page 'reviewed' sometimes not updating #132

Closed ftzohra22 closed 2 years ago

ftzohra22 commented 2 years ago

This happened with a couple papers I was reviewing today. When I click on the mark reviewed button it turned to 'flag for review' without the information displaying the page has been 'reviewed', Refreshing the page doesn't solve the issue either. It's only working if I flag it for review again then mark it as reviewed. image

lwaldron commented 2 years ago

@ftzohra22 can you provide a link to the Study?

ftzohra22 commented 2 years ago

Sorry I fixed that one but here's another example: Experiment 2, Signature 2 ( https://bugsigdb.org/Study_428# )

lwaldron commented 2 years ago

Do you mean experiment 3 signature 2?

lwaldron commented 2 years ago

I think this related to #131 - when you click "mark as reviewed", the change occurs internally but your window doesn't refresh, like we see in the screenshot below including both @ftzohra22 's and my screens, where my newly navigated window shows a review but @ftzohra22, who marked this signature reviewed, does not. I think that's fine for the page to be unrefreshed as long as we know to expect it.

image

lwaldron commented 2 years ago

@ftzohra22 do you know if this was just a matter of the page only showing the review after refreshing? If that's all it is I think we'll close the issue without change, since we are now avoiding refreshing the page after review to speed up reviewing.

ftzohra22 commented 2 years ago

Yes I think that was it. It was taking too long for the 'review' status to get updated unless refreshed and looks like its working fine now. We can close the issue.

tosfos commented 2 years ago

This issue is closed, but noting that we added a follow-up with improved visuals for after the Review button is clicked. Feel fee to create an issue if any changes are needed.