waldronlab / BugSigDB

A microbial signatures database
https://bugsigdb.org
7 stars 6 forks source link

"Cancel" button not working for signatures #162

Closed lwaldron closed 1 year ago

lwaldron commented 1 year ago

When I enter edit mode for any signature, then press the "Cancel" button, nothing happens. I don't see the same issue for studies or experiments.

cmirzayi commented 1 year ago

It's also not working for me.

tosfos commented 1 year ago

It looks like this does actually work, but with certain exceptions. The built-in PageForms cancel button works similarly to a browser back button. So it won't work when opening the edit form in a new tab, or going directly to a Signature edit link like https://bugsigdb.org/Special:FormEdit/Signature/Study_508/Experiment_1/Signature_1?reload=1&returnto=Study_508

You'll see similar behavior for the other forms.

We can improve this functionality if needed, or maybe just remove the "Cancel" link.

lwaldron commented 1 year ago

In that case I'd say just removing the "Cancel" link is good enough, as users will know better what to expect when using the browser back button or closing the tab.

tosfos commented 1 year ago

Done. This can be closed.

lwaldron commented 1 year ago

Thanks!