How to edit allowed values for "Confounders controlled for"?

[lwaldron]

In https://bugsigdb.org/Study_144/Experiment_1 the "Confounders controlled for" contains "peak expiratory flow", which is a valid EFO term) but is being flagged as invalid. There are also other pages containing values that are not EFO terms, but which nonetheless would be nice to allow, to clear the processing errors while requiring consistent use of that term.

Note, there is conflicting documentation about allowed terms:

• https://bugsigdb.org/Help:Admin links to here which looks like:

• And the warning tooltip links to https://bugsigdb.org/Property:Allows_value which links to https://bugsigdb.org/Property:Confounders_controlled_for, which is not an editable list (contains code {{Set validation}})

[tosfos]

It looks like for "Confounders controlled for" (and "Matched on" as well), we are using the same allowed values as in the "Condition" field, which is the cause of the problem. Is it desired for these three fields to use the same list? If so, we'll need to figure out a workaround for this issue. Please advise.

[lwaldron]

"Confounders controlled for" "Matched on" could use the EFO ontology as well, but there are also arguments for treating these two differently than Condition and using instead a manual list for these:

1. they use a much more limited vocabulary than Condition
2. they more commonly have terms not from the EFO. Still not common, but Condition is (almost?) always found in EFO.

However, I can't think of any argument on the user side for "Confounders controlled for" and "Matched on" not using the same list as each other.

[tosfos]

Got it. I'll follow up about this.

[tosfos]

Please see the way we clarified this on the Admin help page. We're also going to improve the warning tooltip.

[tosfos]

This is all ready for review.

New tooltip:

Clicking "Confounders controlled for" brings the user to the new version of the Property page:

Clicking "Edit list" brings up this interface, with some useful notices:

[lwaldron]

This looks good!