search

waldronlab / BugSigDB

A microbial signatures database
https://bugsigdb.org
6 stars 6 forks source link

Allow regular users to leave signature reviews (TSig_Review) #203

Open lwaldron opened 8 months ago

lwaldron commented 8 months ago

If not difficult, I think it would be better to allow regular users to leave reviews on the taxa in signatures without requiring "Reviewer" permissions (ie the green speech bubbles below):

image
tosfos commented 8 months ago

I think we can do that.

tosfos commented 8 months ago

Is it OK if regular users are also allowed to add reviews for the Study, Experiment & Signature pages? It's easier that way. We can also accommodate allowing them to only review taxa.

lwaldron commented 8 months ago

Yes I think that's fine.

lwaldron commented 8 months ago

By "add reviews" for Study, Experiment, & Signature pages, do you mean marking the page as reviewed? If any user can mark those pages as reviewed then as far as I know there will be no additional privileges for "Reviewer". That's maybe suboptimal but I don't think a big deal and I can live with it.

tosfos commented 8 months ago

That is correct. We'll check how difficult it will be to separate the 2 different types of reviews and we'll fall back to allowing all reviews if needed.

tosfos commented 7 months ago

We added a solution to production and it is undergoing testing. Will update soon.

tosfos commented 7 months ago

Regular users should now be able to leave reviews on the taxa in signatures even if they are not in the reviewer group.

tosfos commented 6 months ago

Can this be closed?