search

waldronlab / MultiAssayExperiment

Bioconductor package for management of multi-assay data
https://waldronlab.io/MultiAssayExperiment/
69 stars 32 forks source link

reduce MAE should reorder #188

Closed aedin closed 7 years ago

aedin commented 7 years ago

Hi When using reduce to subset the cases to the intersect, it should reorder the cases such that they are a common order Aedin

LiNk-NY commented 7 years ago

Hi Aedin, @aedin Do you have an example I can work with? AFAIK, the operations in the .harmonize helper achieve this but there could be a bug.

Regards, Marcel

lwaldron commented 7 years ago

In my experience, reduce() does do this successfully - are you using a current development version Aedin?

lwaldron commented 7 years ago

I think that reduce() already does this. @aedin , please re-open if you have an example where it doesn't.

lwaldron commented 7 years ago

re-opened pending unit test.

aedin commented 7 years ago

Hi I was using the current version but I will check it. I will also you code I used Aedin

Sent from my iPhone

On Feb 9, 2017, at 10:37 PM, Levi Waldron notifications@github.com wrote:

In my experience, reduce() does do this successfully - are you using a current development version Aedin?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.