waldronlab / MultiAssayExperiment

Bioconductor package for management of multi-assay data
https://waldronlab.io/MultiAssayExperiment/
69 stars 32 forks source link

Warnings when creating empty objects #268

Closed lgatto closed 4 years ago

lgatto commented 4 years ago

Using the latest devel version, creating empty MultiAssayExperiments and MatchedAssayExperiments throws a warning:

> packageVersion("MultiAssayExperiment")
[1] ‘1.13.14’
> tmp <- MultiAssayExperiment(ExperimentList())
Warning message:
In .sampleMapFromData(colData, experiments) :
  colData rownames and ExperimentList colnames are empty
> tmp <- MatchedAssayExperiment(ExperimentList())
Warning message:
In .sampleMapFromData(colData, experiments) :
  colData rownames and ExperimentList colnames are empty
> tmp <- MultiAssayExperiment()
Warning message:
In .sampleMapFromData(colData, experiments) :
  colData rownames and ExperimentList colnames are empty

In relation to issue #267, I find the release and devel version quite inconsistent.

> packageVersion("MultiAssayExperiment")
[1] ‘1.12.4’
> tmp <- MultiAssayExperiment() ## works
> tmp <- MultiAssayExperiment(ExperimentList()) ## works
> tmp <- MatchedAssayExperiment() ## this one works
> tmp <- MatchedAssayExperiment(ExperimentList()) ## this one fails
Error in MatchedAssayExperiment(ExperimentList()) : 
  Provide a 'MultiAssayExperiment' or its basic components
> packageVersion("MultiAssayExperiment")
[1] ‘1.13.14’
> suppressWarnings(tmp <- MultiAssayExperiment()) ## works
> suppressWarnings(tmp <- MultiAssayExperiment(ExperimentList())) ## works
> suppressWarnings(tmp <- MatchedAssayExperiment()) ## now this one fails
Error in listData[[1L]] : subscript out of bounds
> suppressWarnings(tmp <- MatchedAssayExperiment(ExperimentList())) ## this one works

Ideally, all four calls should return valid empty object.

LiNk-NY commented 4 years ago

Hi Laurent, @lgatto Thanks for reporting the issues. I have updated the devel version of MAE. c7ce350 I will also update the release version shortly. Best, Marcel

LiNk-NY commented 4 years ago

Hi Laurent, @lgatto I've made the changes to the release branch. Thank you for reporting the issue. Best, Marcel

lgatto commented 4 years ago

Thank you, Marcel. Take care!