Tiny detail: warning when subsetting all assays

waldronlab / MultiAssayExperiment

Bioconductor package for management of multi-assay data

https://waldronlab.io/MultiAssayExperiment/

69 stars 32 forks source link

Tiny detail: warning when subsetting all assays #294

Closed cvanderaa closed 3 years ago

cvanderaa commented 3 years ago

Hello!

I have a small issue with the new subsetting behavior. I understand there is now a warning that is thrown when experiments are dropped, but this also happens when subsetting all experiments (so no experiments are dropped), see:

example("MultiAssayExperiment")
mae2 <- mae[, , 1:4]
metadata(mae2)

$drops.experiments
character(0)

It is for sure no major concern, only this makes some of our tests crash and I thought this is not very intuitive.

LiNk-NY commented 3 years ago

Hi Chris, @cvanderaa Thanks for pointing this out. I'll have a look at it today. Best, Marcel

cvanderaa commented 3 years ago

Hi Marcel, @LiNk-NY Thanks a lot for this prompt fix!!