search

waldronlab / MultiAssayExperiment

Bioconductor package for management of multi-assay data
https://waldronlab.io/MultiAssayExperiment/
69 stars 32 forks source link

`na.rm` argument in `subsetByColData` #304

Closed gogonzo closed 1 year ago

gogonzo commented 2 years ago

Referring to the discussion in https://github.com/waldronlab/MultiAssayExperiment/issues/303 Please allow user to specify na.rm in subsetByColData to return data without any errors when column contains NAs

library(MultiAssayExperiment)
subsetByColData(miniACC, DF$race == "white") # error
subsetByColData(miniACC, DF$race == "white", na.rm = TRUE) # to return a MAE without rows having NA in the condition

Thank you, Dawid K

LiNk-NY commented 2 years ago

Thanks. We will update accordingly, depending on the result of the DataFrame issue https://github.com/Bioconductor/S4Vectors/issues/92.

gogonzo commented 2 years ago

Can na.rm be TRUEby default then - to keep it consistent with the MAE from Bioc < 3.14?

LiNk-NY commented 2 years ago

If this gets resolved in DataFrame, this option will not be needed.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.