waldronlab / SingleCellMultiModal

Single Cell multimodal data scripts for downloading datasets
https://bioconductor.org/packages/SingleCellMultiModal
17 stars 9 forks source link

Adding a new dataset: scRNA-Seq + single-cell proteomics (SCoPE2) #26

Closed cvanderaa closed 3 years ago

cvanderaa commented 3 years ago

Hello,

@lgatto and I would like to collaborate on the SingleCellMultiModal project. I here submit a first instance of a PR, but please do not merge yet! I'm following the Contributing-guidelines.Rmd. Details about the data can be found in the documentation R/SCoPE2.R.

TODO

cvanderaa commented 3 years ago

I think it's good on my side. @LiNk-NY, let me know if you have additional remarks.

LiNk-NY commented 3 years ago

Hi Chris, @cvanderaa

Thanks for your contribution! I made some minor changes to the main function. I've tested it locally and it works well. Let's keep an eye out on the Bioconductor builds just in case: https://bioconductor.org/packages/devel/data/experiment/html/SingleCellMultiModal.html

Best, Marcel

cvanderaa commented 3 years ago

Excellent ! Thanks for the code review and for merging!