search

waldronlab / SingleCellMultiModal

Single Cell multimodal data scripts for downloading datasets
https://bioconductor.org/packages/SingleCellMultiModal
17 stars 9 forks source link

ECCITEseq data missing rownames #60

Closed drighelli closed 1 year ago

drighelli commented 1 year ago

Hi @LiNk-NY,

I noticed that the ECCITEseq (also known as CITEseq("peripheral_blood")) data have missing rownames for HTO and ADT assays.

I'm working on this fault, but I'm wondering how do we handle this in the ExperimentHub?

Thanks!

LiNk-NY commented 1 year ago

Hi Dario, @drighelli I think we can just overwrite the data in ExperimentHub since the new change does not change the actual data. Before doing so, you can test that the actual data is identical in both the old and new assays.

drighelli commented 1 year ago

Okay, but what if we subset the data by filtering out some cells?

Do we need to create a version 2.0?

Thanks for the answers!

LiNk-NY commented 1 year ago

Then yes, we'd have to have a new version number.

drighelli commented 1 year ago

this has been solved in https://github.com/waldronlab/SingleCellMultiModal/pull/61