search

waldronlab / SingleCellMultiModal

Single Cell multimodal data scripts for downloading datasets
https://bioconductor.org/packages/SingleCellMultiModal
17 stars 9 forks source link

Ontology IDs #63

Closed kbeckenrode closed 1 year ago

kbeckenrode commented 1 year ago

Here are the ontology IDs, but it doesn't align with what I currently see in the repo. @LiNk-NY @drighelli

shbrief commented 1 year ago

It seems like you sent the pull request from one of your working branches to the master branch within your own cloned repository, so it'll not affect the master branch of this repository.

Btw, it looks like you closed that pull request without merging, so the master branch of your repository is not updated either. One more side note, there is a typo - an underscore in 4E of your Google Sheet, which should be "Primitive Streak". Also, I think row 13 mapping will be better with "CD8-Positive T-Lymphocyte (NCIT:C12542)", using the same ontology DB as the related terms.

drighelli commented 1 year ago

Thanks @kbeckenrode for the cell ontology.

It isn't alligned because yesterday @LiNk-NY merged the last version of the ontomap (based on https://github.com/waldronlab/SingleCellMultiModal/pull/58 discussion) into the master branch of the repo.

I'll merge both versions in a new PR.

drighelli commented 1 year ago

this has been solved in https://github.com/waldronlab/SingleCellMultiModal/pull/64