waldronlab / SingleCellMultiModal

Single Cell multimodal data scripts for downloading datasets
https://bioconductor.org/packages/SingleCellMultiModal
17 stars 9 forks source link

Citeseq celltypes #69

Closed drighelli closed 1 year ago

drighelli commented 1 year ago

adding code, metadata, script, new functions and ontomap for the cord_blood identified celltypes.

drighelli commented 1 year ago

There was a conflict that has been resolved by adding the new code in the .cord_blood function. It solves a bug where the cd could be also an empty object.

LiNk-NY commented 1 year ago

Please try to avoid merge commits with devel and instead checkout from devel and commit your changes on top of the branch. That is:

git checkout -b new_branch origin/devel
git commit # etc.
git push origin new_branch
LiNk-NY commented 1 year ago

Merged with rebase to clean up the merge commit. Thanks!

LiNk-NY commented 1 year ago

@drighelli Note. Make sure that the BiocVersion matches the current devel version 3.18 in the metadata.csv.

I have updated this.

drighelli commented 1 year ago

ok, sorry for the errors!