search

waldronlab / bugsigdbr

R-side access to published microbial signatures from BugSigDB
https://bioconductor.org/packages/bugsigdbr
GNU General Public License v3.0
4 stars 2 forks source link

Update default importBugSigDB to v1.1.0 #31

Closed jwokaty closed 2 years ago

jwokaty commented 2 years ago

@lgeistlinger Do we need to update the NEWS.md file?

I've updated the default to point to the new files on Zenodo and bumped the version.

Close #30

lgeistlinger commented 2 years ago

Thanks @jwokaty. No need to update the NEWS file beyond what's already there I think. I noticed two things:

  1. Did you maybe forget to roxygenize after updating the version argument as the checks fail due to documentation mismatch?
  2. The new release on zenodo says "Publication date: January 25, 2022" but it should be "April 18, 2022", no?
jwokaty commented 2 years ago

I did forget to roxygenize and also to click publish again to update the publication date. thanks for spotting these issues.

jwokaty commented 2 years ago

Getting a 503 trying to download from zenodo, which is why the checks are failing:

wget https://zenodo.org/record/6468009/files/full_dump.csv?download=1
--2022-04-19 15:51:36--  https://zenodo.org/record/6468009/files/full_dump.csv?download=1
Resolving zenodo.org (zenodo.org)... 137.138.76.77
Connecting to zenodo.org (zenodo.org)|137.138.76.77|:443... connected.
HTTP request sent, awaiting response... 503 Service Unavailable
2022-04-19 15:53:37 ERROR 503: Service Unavailable.

Will try again later.