search

waldronlab / cBioPortalData

Integrate the cancer genomics portal, cBioPortal, using MultiAssayExperiment
https://waldronlab.io/cBioPortalData/
30 stars 12 forks source link

Fix cBioDataPack error on non-char Patient ID #27

Closed jucor closed 4 years ago

jucor commented 4 years ago

cBioDataPack() smartly checks patient IDs for the prefix "TCGA" to remove it if needed. That checks errors when the patient ID is not numeric.

Not all studies' patient IDs are characters. For example, coadread_genentech's patient IDs are numeric. Modifying the test to first check if the IDs are character solves the problem.

Fixes #25.

lwaldron commented 4 years ago

Thank you Julien, @jucor!!! Really appreciated.

jucor commented 4 years ago

With pleasure :) Thanks for your hard work!

On Mon, 13 Jul 2020, 17:21 Levi Waldron, notifications@github.com wrote:

Thank you Julien, @jucor https://github.com/jucor!!! Really appreciated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/waldronlab/cBioPortalData/pull/27#issuecomment-657623906, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFBERO2E7IQDFFVRY6PBDDR3MRAHANCNFSM4OX2QLOA .