waldronlab / curatedMetagenomicDataCuration

Sample Metadata Curation for curatedMetagenomicData
https://waldronlab.io/curatedMetagenomicDataCuration/
28 stars 23 forks source link

create "recommended" option for requiredness in template.csv #2

Open lwaldron opened 6 years ago

lwaldron commented 6 years ago

Currently, only "required" or "optional" are permissible. Add "warning" as a possibility, and this will return a warning in the check and in the produced vignette.

lwaldron commented 3 years ago

@paolinomanghi @edoardopasolli where should there be a "warning" option in the template? If it is added we can use it.

edoardopasolli commented 3 years ago

I would put it in: antibiotics_current_use disease study_condition age_category gender country non_westernized These are "optional" fields, but I think a curator should be able to get them in most of the cases

paolinomanghi commented 3 years ago

I would use as a mandatory also

I'd rather not consider sex (gender) as mandatory because is not guaranteed to have it (some modern policies prefer not to deploy it, see the latest Zeharnakova paper), also when other nice metadata are available. Instead, for example, age_category is almost alwasy retrievable looking into the paper.

On Mon, Jan 4, 2021 at 5:06 PM edoardopasolli notifications@github.com wrote:

I would put it in: antibiotics_current_use disease study_condition age_category gender country non_westernized These are "optional" fields, but I think a curator should be able to get them in most of the cases

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/waldronlab/curatedMetagenomicDataCuration/issues/2#issuecomment-754062881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZXSV6MQWNUNT77AKQRMIDSYHRRHANCNFSM4EBPGEVQ .

lwaldron commented 3 years ago

Call this "recommended" instead.