waldur / waldur-homeport

Waldur HomePort is web-based client for the Waldur MasterMind.
MIT License
23 stars 27 forks source link

Error on adding public offering #9

Closed rohitbatham closed 4 years ago

rohitbatham commented 4 years ago

Hi @AmbientLighter , @mikeyakymenko, @RonBalnen,

You guys are really doing an amazing job! using great tech stack and this tool has lots of features. I recently installed it on my machine.

but I don't know I am asking the right question or not even I might be wrong as i have least insight about the application workflow. Still seeking your help here.

Problem

After creating organization, I am adding public offering but it throws an error. please refer the snapshot.

Console error

image

I am done with my initial analysis and then went though the debugger and I noticed its happening because formatOfferingRequest method is expecting an argument component which is empty from service. refer below snapshot

Server response

image

And the code is breaking on file waldur-homeport\src\marketplace\offerings\store\effects.ts line no. 68 as component is being passed null.

When i jumped inside the method which is located on waldur-homeport\src\marketplace\offerings\store\utils.ts line no. 104 method formatOfferingRequest so this is actually breaks on highlighted code snippet.

Code

image

I don't know whats wrong here. Is it really mandatory to pass component if yes how and from where?

Looking forward for your response!

Thank you

AmbientLighter commented 4 years ago

Hi, @rohitbatham

Thank you for the bug report, I will look into this issue and update you on its progress.

AmbientLighter commented 4 years ago

This bug has been fixed in https://github.com/opennode/waldur-homeport/commit/ca9cc82f41be600cd4bfa051b52569993816f764